Skip to content

fix: Fix unit selection in file type#3410

Merged
Chartman123 merged 1 commit into
mainfrom
bugfix/fix-unit-selection
Jun 12, 2026
Merged

fix: Fix unit selection in file type#3410
Chartman123 merged 1 commit into
mainfrom
bugfix/fix-unit-selection

Conversation

@Koc

@Koc Koc commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Closes #3408

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Koc Koc self-assigned this Jun 10, 2026
@Chartman123

Chartman123 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Nice, thanks :) do we have to adjust the other @input's in the menu, too?

@Koc

Koc commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

I thought about that as well 🤝 but it works fine with even with @input 🤷‍♂️ . So I've decided to reduce amount of changes.

If you want - I can adjust all of them, just say

@Chartman123

Copy link
Copy Markdown
Collaborator

Yes, would be nice :)

@input is no longer listed in the events section of the style guide. so might stop working sometime in the future :)

https://nextcloud-vue-components.netlify.app/#/Components/NcActions

Please also have a look at the custom file extensions, in my prod instance the field only takes numbers

@Koc

Koc commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

@Chartman123 I did more changes, but...

  1. there are short answer question type that relies on event?.isComposing (used for Chineese/Japanese). Sorry, but I have no any idea how to combine this with update:modelValue, it seems like we still need @input for that
  2. extension selection not works for me. It works fine for vue-select but not works for Nextcloud wrapper. Looks like a bug on nextcloud-libraries/nextcloud-vue side

feel free to push to my branch

@Chartman123

Chartman123 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator
  1. it seems like we still need @input for that

Yes, I think so, too 👍🏻

I could fix the extension selection by adding a key to the NcActionInput. Please test it :) If it's working on your instance, too, you can squash the commits and rebase on main :)

@Chartman123

Copy link
Copy Markdown
Collaborator

/backport to stable5.3

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jun 11, 2026
Comment thread src/components/Questions/QuestionShort.vue Outdated
@Koc Koc force-pushed the bugfix/fix-unit-selection branch from dba300f to da58ca5 Compare June 11, 2026 22:52
@Koc

Koc commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

wow, with key helped. But how it works? Was the problem caused by reusing of another component?

I've reverted changes in the QuestionShort.vue (see comment)

@Chartman123

Copy link
Copy Markdown
Collaborator

Copilot suggested that it might have come from and interfered with some other type value in the attrs passed to the component...

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the bugfix/fix-unit-selection branch from da58ca5 to ee174d4 Compare June 11, 2026 23:03
@Chartman123 Chartman123 merged commit b892b2c into main Jun 12, 2026
43 checks passed
@Chartman123 Chartman123 deleted the bugfix/fix-unit-selection branch June 12, 2026 09:37
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit selection for files question not working correctly

2 participants